egtyl/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) (#21738)

Browse source 
Backport #21734

fixes: https://github.com/go-gitea/gitea/issues/21733

Uncaught Error: Language id "vs.editor.nullLanguage" is not configured
nor known

Note that this monaco-editor worked fine on 0.33.0 and broke on 0.34.0.
If upstream fixed, remove this code.

Signed-off-by: Xinyu Zhou <i@sourcehut.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
Xinyu Zhou 2022-11-09 21:19:44 +08:00 committed by GitHub
parent e054f80fe0
commit 69a54545a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
web_src/js/bootstrap.js vendored
View file

@ -26,9 +26,6 @@ function processWindowErrorEvent(e) {
return; // ignore such nonsense error event return; // ignore such nonsense error event
} }
// Wait for upstream fix: https://github.com/microsoft/monaco-editor/issues/2962
if (e.message.includes('Language id "vs.editor.nullLanguage" is not configured nor known')) return;
showGlobalErrorMessage(`JavaScript error: ${e.message} (${e.filename} @ ${e.lineno}:${e.colno}). Open browser console to see more details.`); showGlobalErrorMessage(`JavaScript error: ${e.message} (${e.filename} @ ${e.lineno}:${e.colno}). Open browser console to see more details.`);
} }

4
web_src/js/features/codeeditor.js
View file

@ -99,6 +99,10 @@ export async function createMonaco(textarea, filename, editorOpts) {
} }
}); });
// Quick fix: https://github.com/microsoft/monaco-editor/issues/2962
monaco.languages.register({id: 'vs.editor.nullLanguage'});
monaco.languages.setLanguageConfiguration('vs.editor.nullLanguage', {});
const editor = monaco.editor.create(container, { const editor = monaco.editor.create(container, {
value: textarea.value, value: textarea.value,
theme: 'gitea', theme: 'gitea',