egtyl/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix duplicate ID when deleting repo (#28520) (#28528)

Browse source 
Backport #28520 by @framitdavid


There is an accessibility issue in the interface when attempting to
delete a repository. When I click on "Delete repository," a dialog box
appears, requiring confirmation to proceed with the repository deletion.
However, when I press the "Repo name" label, the wrong input field gains
focus. The focused field is located behind the dialog and is intended
for renaming the repository.

I am submitting these pull requests to ensure that the correct input
field is focused when the user clicks on the label. This change will
also facilitate the writing of tests using Playwright or Testing Library
to retrieve elements based on roles. This PR will also improve
acessibility of this area.

Co-authored-by: David Øvrelid <46874830+framitdavid@users.noreply.github.com>
This commit is contained in:
Giteabot 2023-12-19 16:40:03 +08:00 committed by GitHub
parent d9aeb1f09d
commit 932e282e15
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
templates/repo/migrate/migrating.tmpl
View file

@ -73,8 +73,8 @@
</label> </label>
</div> </div>
<div class="required field"> <div class="required field">
<label for="repo_name">{{ctx.Locale.Tr "repo.repo_name"}}</label> <label for="repo_name_to_delete">{{ctx.Locale.Tr "repo.repo_name"}}</label>
<input id="repo_name" name="repo_name" required> <input id="repo_name_to_delete" name="repo_name" required>
</div> </div>
<div class="text right actions"> <div class="text right actions">

4
templates/repo/settings/options.tmpl
View file

@ -921,8 +921,8 @@
</label> </label>
</div> </div>
<div class="required field"> <div class="required field">
<label for="repo_name">{{ctx.Locale.Tr "repo.repo_name"}}</label> <label for="repo_name_to_delete">{{ctx.Locale.Tr "repo.repo_name"}}</label>
<input id="repo_name" name="repo_name" required> <input id="repo_name_to_delete" name="repo_name" required>
</div> </div>
<div class="text right actions"> <div class="text right actions">