egtyl/forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add null check for responseData.invalidTopics (#32212)

Browse source 
<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe">

`responseData.invalidTopics` can be null but it wasn't handled.

(cherry picked from commit 2e12343fc4ca96a215d6820c4467b619eaa5cbe9)
This commit is contained in:
cloudchamb3r 2024-10-09 02:27:05 +09:00 committed by Earl Warren
parent d0af8fe4dc
commit eff28911d3
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web_src/js/features/repo-home.js
View file

@ -60,7 +60,7 @@ export function initRepoTopicBar() {
// how to test: input topic like " invalid topic " (with spaces), and select it from the list, then "Save" // how to test: input topic like " invalid topic " (with spaces), and select it from the list, then "Save"
const responseData = await response.json(); const responseData = await response.json();
lastErrorToast = showErrorToast(responseData.message, {duration: 5000}); lastErrorToast = showErrorToast(responseData.message, {duration: 5000});
if (responseData.invalidTopics.length > 0) { if (responseData.invalidTopics && responseData.invalidTopics.length > 0) {
const {invalidTopics} = responseData; const {invalidTopics} = responseData;
const topicLabels = queryElemChildren(topicDropdown, 'a.ui.label'); const topicLabels = queryElemChildren(topicDropdown, 'a.ui.label');
for (const [index, value] of topics.split(',').entries()) { for (const [index, value] of topics.split(',').entries()) {