mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-30 18:22:14 +01:00
dd30d9d5c0
The function `GetByBean` has an obvious defect that when the fields are
empty values, it will be ignored. Then users will get a wrong result
which is possibly used to make a security problem.
To avoid the possibility, this PR removed function `GetByBean` and all
references.
And some new generic functions have been introduced to be used.
The recommand usage like below.
```go
// if query an object according id
obj, err := db.GetByID[Object](ctx, id)
// query with other conditions
obj, err := db.Get[Object](ctx, builder.Eq{"a": a, "b":b})
```
51 lines
1.6 KiB
Go
51 lines
1.6 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package system_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/system"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestSettings(t *testing.T) {
|
|
keyName := "test.key"
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
assert.NoError(t, db.TruncateBeans(db.DefaultContext, &system.Setting{}))
|
|
|
|
rev, settings, err := system.GetAllSettings(db.DefaultContext)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1, rev)
|
|
assert.Len(t, settings, 1) // there is only one "revision" key
|
|
|
|
err = system.SetSettings(db.DefaultContext, map[string]string{keyName: "true"})
|
|
assert.NoError(t, err)
|
|
rev, settings, err = system.GetAllSettings(db.DefaultContext)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 2, rev)
|
|
assert.Len(t, settings, 2)
|
|
assert.EqualValues(t, "true", settings[keyName])
|
|
|
|
err = system.SetSettings(db.DefaultContext, map[string]string{keyName: "false"})
|
|
assert.NoError(t, err)
|
|
rev, settings, err = system.GetAllSettings(db.DefaultContext)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 3, rev)
|
|
assert.Len(t, settings, 2)
|
|
assert.EqualValues(t, "false", settings[keyName])
|
|
|
|
// setting the same value should not trigger DuplicateKey error, and the "version" should be increased
|
|
err = system.SetSettings(db.DefaultContext, map[string]string{keyName: "false"})
|
|
assert.NoError(t, err)
|
|
|
|
rev, settings, err = system.GetAllSettings(db.DefaultContext)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, settings, 2)
|
|
assert.EqualValues(t, 4, rev)
|
|
}
|