forgejo/cmd
Giteabot 00cd5ba6f4
fixed duplicate attachments on dump on windows (#28019) (#28031)
Backport #28019 by @anudeepreddy

Hi,

This PR fixes #27988. The use of `path.join`(which uses `/` as the file
separator) to construct paths and comparing them with paths constructed
using `filepath.join`(which uses platform specific file separator) is
the root cause of this issue.

The desired behavior is to ignore attachments when dumping data
directory. Due to the what's mentioned above, the function
`addRecursiveExclude` is not actually ignoring the attachments directory
and is being written to the archive. The attachment directory is again
added to the archive (with different file separator as mentioned in the
issue) causing a duplicate entry on windows.

The solution is to use `filepath.join` in `addResursiveExclude` to
construct `currentAbsPath`.

Co-authored-by: Anudeep Reddy <anudeepc85@gmail.com>
2023-11-14 09:56:21 +08:00
..
actions.go
admin.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
admin_auth_ldap.go
admin_auth_ldap_test.go
admin_user.go
admin_user_change_password.go
admin_user_create.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
admin_user_delete.go
admin_user_generate_access_token.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
admin_user_list.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
admin_user_must_change_password.go
cert.go Expanded minimum RSA Keylength to 3072 (#26604) 2023-08-28 00:53:16 +00:00
cmd.go
docs.go
doctor.go
doctor_convert.go
dump.go fixed duplicate attachments on dump on windows (#28019) (#28031) 2023-11-14 09:56:21 +08:00
dump_repo.go
embedded.go
generate.go Handle base64 decoding correctly to avoid panic (#26483) 2023-08-14 10:30:16 +00:00
hook.go
hook_test.go
keys.go
mailer.go
main.go
main_test.go
manager.go
manager_logging.go
migrate.go
migrate_storage.go fix: typo (#27009) 2023-09-11 09:30:18 +00:00
migrate_storage_test.go Another round of db.DefaultContext refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
restore_repo.go
serv.go
web.go Refactor tests (#26464) 2023-08-12 16:30:16 +00:00
web_acme.go
web_graceful.go
web_https.go