forgejo/modules
forgejo-backport-action 9f80081795 [v7.0/forgejo] [REFACTOR] git attribute: test proper cancellation and unify nul-byte reader (#2939)
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/2906

Following #2763 (refactor of git check-attr)
and #2866 (wrong log.Error format in check-attr)

- refactors the `nul-byte` reader to be used in both the streaming and one-off cases.
- add test for some failure cases
- don't log the error returned by `cmd.Run`, but return it to the `CheckPath` caller (which can then decide what to do with it).

This should solve the following flaky `log.Error` (or at least move it to the caller, instead of being inside a random goroutine):

https://codeberg.org/forgejo/forgejo/actions/runs/9541/jobs/5#jobstep-7-839

> FATAL ERROR: log.Error has been called: 2024/03/28 14:30:33 ...it/repo_attribute.go:313:func2() [E] Unable to open checker for 3fa2f829675543ecfc16b2891aebe8bf0608a8f4. Error: failed to run attr-check. Error: exit status 128
        Stderr: fatal: this operation must be run in a work tree

Co-authored-by: oliverpool <git@olivier.pfad.fr>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2939
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
2024-04-01 06:44:46 +00:00
..
actions Merge pull request '[ACTIONS] port scheduled actions from Gitea' (#2826) from earl-warren/forgejo:wip-gitea-schedule into forgejo 2024-03-27 06:23:56 +00:00
activitypub
analyze
assetfs
auth Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
avatar
base Refactor StringsToInt64s (#29967) 2024-03-26 19:04:26 +01:00
cache
charset [FEAT] Enable ambiguous character detection in configured contexts 2024-02-23 13:12:17 +01:00
container
csv Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
emoji
eventsource
generate Port "Use general token signing secret" 2024-02-19 20:49:37 +01:00
git [v7.0/forgejo] [REFACTOR] git attribute: test proper cancellation and unify nul-byte reader (#2939) 2024-04-01 06:44:46 +00:00
gitgraph
gitrepo Move get/set default branch from git package to gitrepo package to hide repopath (#29126) 2024-03-11 23:36:59 +07:00
graceful Remove unused error in graceful manager (#29871) 2024-03-26 19:04:25 +01:00
hcaptcha
highlight
hostmatcher
html
httpcache
httplib
indexer Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (#29990) 2024-03-30 07:17:29 +01:00
issue/template Extend issue template yaml engine (#29274) 2024-03-06 12:10:47 +08:00
json
label
lfs
log
markup [BUG] Don't color dot literal color names 2024-03-30 22:12:40 +00:00
mcaptcha
metrics
migration Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
nosql
optional migrate some more "OptionalBool" to "Option[bool]" (#29479) 2024-03-06 12:10:44 +08:00
options
packages
paginator
pprof
private
process
proxy
proxyprotocol
public
queue workergroup: gracefully exit on close(popItemErr) 2024-03-24 07:12:31 +01:00
recaptcha
references Fix issue link does not support quotes (#29484) (#29487) 2024-03-06 12:10:45 +08:00
regexplru
repository Move generate from module to service (#29465) 2024-03-06 12:10:44 +08:00
secret
session
setting Remember login for a month by default (#30150) 2024-03-30 07:17:31 +01:00
sitemap
ssh
storage Add minio bucket lookup type option 2024-03-06 09:38:02 +00:00
structs [REFACTOR] webhook.Handler interface 2024-03-24 10:35:06 +01:00
svg
sync
system
templates Render code tags in commit messages (#30146) 2024-03-30 07:17:32 +01:00
test [TESTS] add log.Level to test.NewLogChecker 2024-02-05 16:54:44 +01:00
testlogger [I18N] Add missing translation for more_items 2024-03-26 22:39:46 +05:00
timeutil Remove the time-since class (#29826) 2024-03-20 08:46:30 +01:00
translation log.Error on missing translation 2024-03-24 07:11:18 +01:00
turnstile
typesniffer
updatechecker
uri
user
util Revert "cherry pick only IfZero from (#29755)" 2024-03-28 11:46:41 +00:00
validation
web [REFACTOR] webhook matrix endpoints 2024-03-27 15:38:38 +01:00
webhook Fix schedule tasks bugs (#28691) 2024-03-25 16:25:02 +01:00