forgejo/templates/repo
oliverpool 937b8e8184
fix: release page for empty or non-existing target (#24659)
Backport #24470

Fixes #24145

---

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.

_contributed in the context of @forgejo_

(cherry picked from commit cb7ba8969d)
2023-05-16 07:42:22 +02:00
..
actions Fix actions frontend bugs (pagination, long name alignment) and small simplify (#23370) (#23436) 2023-03-13 09:09:00 +02:00
branch Make branches list page operations remember current page (#23420) (#23460) 2023-03-14 20:51:14 +08:00
cite Copy citation file content, in APA and BibTex format, on repo home page (#19999) 2022-11-11 18:02:50 +01:00
diff Fix code view (diff) broken layout (#23096) (#23918) 2023-04-04 16:02:29 +02:00
editor Fix broken code editor diff preview (#23307) (#23320) 2023-03-06 12:05:35 -06:00
find Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
graph Improve commit graph page UI alignment (#23751) (#23754) 2023-03-27 17:27:08 -04:00
issue Improve milestone filter on issues page (#22423) (#24440) 2023-04-30 19:01:12 +02:00
migrate [BRANDING] Custom loading animation for Forgejo 2023-05-10 11:05:21 +02:00
projects Fix no edit/close/delete button in org repo project view page (#24349) 2023-04-26 07:38:41 -04:00
pulls Discolor pull request tab labels (#23950) (#23987) 2023-04-07 22:32:42 -04:00
release fix: release page for empty or non-existing target (#24659) 2023-05-16 07:42:22 +02:00
settings [BRANDING] define the forgejo webhook type 2023-05-10 11:05:22 +02:00
tag Add tags list for repos whose release setting is disabled (#23465) (#24369) 2023-04-27 12:40:36 +08:00
wiki Fix new wiki page mirror (#24518) 2023-05-04 16:30:47 -04:00
activity.tmpl Add context when rendering labels or emojis (#23281) (#23319) 2023-03-06 10:32:40 -06:00
blame.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
branch_dropdown.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
clone_buttons.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
clone_script.tmpl Make clone URL use current page's host (#22808) 2023-02-09 17:29:13 +08:00
commit_page.tmpl Use octicon-verified for gpg signatures (#23529) (#23536) 2023-03-17 11:39:31 -04:00
commit_status.tmpl Fix missing commit status in PR which from forked repo (#23351) (#23453) 2023-03-14 08:11:31 +08:00
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
commits.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
commits_list.tmpl Add context when rendering labels or emojis (#23281) (#23319) 2023-03-06 10:32:40 -06:00
commits_list_small.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
commits_table.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
create.tmpl Make label templates have consistent behavior and priority (#23749) (#24071) 2023-04-12 16:05:10 +02:00
create_helper.tmpl Add templates to customize text when creating and migrating repositories 2023-01-24 22:36:48 -05:00
empty.tmpl Fix broken clone script on an empty archived repo (#24339) (#24348) 2023-04-26 10:13:16 +02:00
file_info.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
forks.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
graph.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
header.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
home.tmpl Fix and move "Use this template" button (#23398) (#23408) 2023-03-11 01:41:04 +08:00
icon.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
packages.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
search.tmpl Fix 'View File' button in code search (#23478) (#23483) 2023-03-15 10:34:05 +01:00
shabox_badge.tmpl Fix shabox regression (#22924) 2023-02-16 09:37:11 +08:00
sub_menu.tmpl Add tags list for repos whose release setting is disabled (#23465) (#24369) 2023-04-27 12:40:36 +08:00
sub_menu_release_tag.tmpl Add tags list for repos whose release setting is disabled (#23465) (#24369) 2023-04-27 12:40:36 +08:00
unicode_escape_prompt.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
upload.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
user_cards.tmpl Fix user-cards format (#24428) (#24431) 2023-04-29 22:05:34 -04:00
view_file.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
view_list.tmpl Add wrapper to author to avoid long name ui problem (#23030) (#23098) 2023-02-24 10:45:18 +08:00
watchers.tmpl Fix user-cards format (#24428) (#24431) 2023-04-29 22:05:34 -04:00