mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-26 00:03:35 +01:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
110 lines
3.1 KiB
Go
110 lines
3.1 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package setting
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/context"
|
|
auth "code.gitea.io/gitea/modules/forms"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/web"
|
|
|
|
"github.com/tstranex/u2f"
|
|
)
|
|
|
|
// U2FRegister initializes the u2f registration procedure
|
|
func U2FRegister(ctx *context.Context) {
|
|
form := web.GetForm(ctx).(*auth.U2FRegistrationForm)
|
|
if form.Name == "" {
|
|
ctx.Error(409)
|
|
return
|
|
}
|
|
challenge, err := u2f.NewChallenge(setting.U2F.AppID, setting.U2F.TrustedFacets)
|
|
if err != nil {
|
|
ctx.ServerError("NewChallenge", err)
|
|
return
|
|
}
|
|
if err := ctx.Session.Set("u2fChallenge", challenge); err != nil {
|
|
ctx.ServerError("Unable to set session key for u2fChallenge", err)
|
|
return
|
|
}
|
|
regs, err := models.GetU2FRegistrationsByUID(ctx.User.ID)
|
|
if err != nil {
|
|
ctx.ServerError("GetU2FRegistrationsByUID", err)
|
|
return
|
|
}
|
|
for _, reg := range regs {
|
|
if reg.Name == form.Name {
|
|
ctx.Error(409, "Name already taken")
|
|
return
|
|
}
|
|
}
|
|
if err := ctx.Session.Set("u2fName", form.Name); err != nil {
|
|
ctx.ServerError("Unable to set session key for u2fName", err)
|
|
return
|
|
}
|
|
// Here we're just going to try to release the session early
|
|
if err := ctx.Session.Release(); err != nil {
|
|
// we'll tolerate errors here as they *should* get saved elsewhere
|
|
log.Error("Unable to save changes to the session: %v", err)
|
|
}
|
|
ctx.JSON(200, u2f.NewWebRegisterRequest(challenge, regs.ToRegistrations()))
|
|
}
|
|
|
|
// U2FRegisterPost receives the response of the security key
|
|
func U2FRegisterPost(ctx *context.Context) {
|
|
response := web.GetForm(ctx).(*u2f.RegisterResponse)
|
|
challSess := ctx.Session.Get("u2fChallenge")
|
|
u2fName := ctx.Session.Get("u2fName")
|
|
if challSess == nil || u2fName == nil {
|
|
ctx.ServerError("U2FRegisterPost", errors.New("not in U2F session"))
|
|
return
|
|
}
|
|
challenge := challSess.(*u2f.Challenge)
|
|
name := u2fName.(string)
|
|
config := &u2f.Config{
|
|
// Chrome 66+ doesn't return the device's attestation
|
|
// certificate by default.
|
|
SkipAttestationVerify: true,
|
|
}
|
|
reg, err := u2f.Register(*response, *challenge, config)
|
|
if err != nil {
|
|
ctx.ServerError("u2f.Register", err)
|
|
return
|
|
}
|
|
if _, err = models.CreateRegistration(ctx.User, name, reg); err != nil {
|
|
ctx.ServerError("u2f.Register", err)
|
|
return
|
|
}
|
|
ctx.Status(200)
|
|
}
|
|
|
|
// U2FDelete deletes an security key by id
|
|
func U2FDelete(ctx *context.Context) {
|
|
form := web.GetForm(ctx).(*auth.U2FDeleteForm)
|
|
reg, err := models.GetU2FRegistrationByID(form.ID)
|
|
if err != nil {
|
|
if models.IsErrU2FRegistrationNotExist(err) {
|
|
ctx.Status(200)
|
|
return
|
|
}
|
|
ctx.ServerError("GetU2FRegistrationByID", err)
|
|
return
|
|
}
|
|
if reg.UserID != ctx.User.ID {
|
|
ctx.Status(401)
|
|
return
|
|
}
|
|
if err := models.DeleteRegistration(reg); err != nil {
|
|
ctx.ServerError("DeleteRegistration", err)
|
|
return
|
|
}
|
|
ctx.JSON(200, map[string]interface{}{
|
|
"redirect": setting.AppSubURL + "/user/settings/security",
|
|
})
|
|
}
|